♻️ Refactor/OC-681/verbeteringen-footer-template #254
Conversation
|
Tijdelijke oplossing |
pwa/static/themes/rotterdam.css
Outdated
| --web-app-color-background-footer: #eff4f6; | ||
| --web-app-color-footer-headings: auto; | ||
| --web-app-color-footer-links: var(--web-app-color-black); | ||
| --web-app-color-background-footer: #00811f; |
There was a problem hiding this comment.
Gebruik in plaats van de hex kleur liever var(--rotterdam-color-base-green).
Je kunt hier de color tokens opzoeken: https://nl-design-system.github.io/themes/?path=/story/rotterdam-color--page
Dit geldt eigenlijk ook voor alle andere kleuren in .rotterdam-theme, zoals var(--web-app-color-white), daar kun je beter var(--rotterdam-color-base-white) gebruiken.
Ridsko
changed the title
AliKdhim87
force-pushed
the
NL-Design-System-Changes
branch
2 times, most recently
from
0b873ce to
d55f8cc
Compare
Ridsko
force-pushed
the
NL-Design-System-Changes
branch
from
e975d21 to
d55f8cc
Compare
|
De footer word beter geimplementeerd/gebruikt in deze PR |
lencodes
left a comment
lencodes
left a comment
There was a problem hiding this comment.
Nice changes to the ThemeSwitcher! Much better this way.
I did leave one comment that we should fix before merging this.
| --web-app-footer-logo-container-height: 50px; | ||
| --web-app-footer-organization-logo-width: 230px; | ||
| --web-app-footer-organization-logo-src: url("images/LogoRotterdam.svg"); | ||
| --web-app-footer-organization-logo-wit-src: url("images/LogoRotterdamWit.svg"); |
There was a problem hiding this comment.
Nice addition. However, when adding a new design token to a theme it's very important that we add them to the other themes as well.
In this case: we need to add it to the base theme ".web-app-theme" and the Utrecht theme ".utrecht-theme".
The effect of not adding the new token to the other themes:
There was a problem hiding this comment.
Sorry this pr should be closed, the improved footer is in this PR
No description provided.