Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the link to documents in README.md File. #1491

Conversation

secretkontributer
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Copy link

welcome bot commented Dec 3, 2023

Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests.

@ghutchis
Copy link
Member

ghutchis commented Dec 3, 2023

Thanks - we require contributions to sign off commits with full names, e.g.
https://github.com/OpenChemistry/avogadrolibs/pull/1491/checks?check_run_id=19262890895

@secretkontributer
Copy link
Contributor Author

I signed-off my commit is there anything else i am need to do sir?

@ghutchis
Copy link
Member

ghutchis commented Dec 3, 2023

Yeah, your sign-off is "secretkontributer" which isn't your full name.

Thanks

Signed-off-by: secretkontributer <kiran29iitm@gmail.com>
@secretkontributer secretkontributer force-pushed the feature-branch branch 5 times, most recently from 93b0aab to e522cda Compare December 3, 2023 17:18
@secretkontributer
Copy link
Contributor Author

I am not abled to with my full name can you please guide me

@secretkontributer
Copy link
Contributor Author

Sorry for the inconvenience this is my first pr

@ghutchis
Copy link
Member

ghutchis commented Dec 4, 2023

No worries. That's the point of the welcome message.

git config user.name "FIRST_NAME LAST_NAME"

Then you'll need to amend the previous commit:

git commit --amend --signoff
git push -f

e.g. https://docs.pi-hole.net/guides/github/how-to-signoff/

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member

ghutchis commented Dec 5, 2023

BTW, I still can't merge this because it has your full name as "secretkontributer". Thanks.

@ghutchis
Copy link
Member

I'm going to close this. Please set your name with git config user.name "FIRST_NAME LAST_NAME" and re-open a pull request. Thanks.

@ghutchis ghutchis closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants