Fixed Menu Tab options Bugs #1500
Conversation
Signed-off-by: secretkontributer <kiran29iitm@gmail.com>
|
My PR contains fixed code of both the issues i raised on discussion forum. |
avogadro/qtplugins/select/select.cpp
Outdated
| @@ -544,6 +550,9 @@ void Select::createLayerFromSelection() | |||
| if (!m_molecule) | |||
| return; | |||
|
|
|||
| if(!m_elements) | |||
There was a problem hiding this comment.
This is definitely not the right fix. That's a dialog if someone wants to select elements. If someone opens the "Select by Elements" the dialog will be created.
I'd check to see if the molecule has atoms?
There was a problem hiding this comment.
I can use m_molecule->atomCount() to check this
There was a problem hiding this comment.
but i think we need to select atoms first to create a newLayer
There was a problem hiding this comment.
thats the reason i went with this solution
There was a problem hiding this comment.
I have made relevant changes you can check it
There was a problem hiding this comment.
I have updated according to the latest PR of issue 1499
|
See if #1499 solves your crashes. |
|
Here are the build results |
Signed-off-by: secretkontributer <kiran29iitm@gmail.com>
Signed-off-by: secretkontributer <kiran29iitm@gmail.com>
Signed-off-by: secretkontributer <kiran29iitm@gmail.com>
|
I'm closing this because the tests didn't run. It's now in #1625 - the code looks good so let's make sure everything passes. Thanks and sorry for the delay |
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.