style: run clang-format #2065
style: run clang-format #2065
Conversation
| @@ -43,15 +43,18 @@ class ArrayRefContainer | |||
| explicit ArrayRefContainer(const size_t n, | |||
| const ValueType& value = ValueType()) | |||
| : m_ref(1), data(n, value) | |||
| {} | |||
There was a problem hiding this comment.
I definitely don't like this change. It's adding a lot of un-needed linebreaks.
AllowShortBlocksOnASingleLine: Empty
There was a problem hiding this comment.
Ugh, I tried Empty but it does not work as expected.
I am using clang-format 20.1.6.
There was a problem hiding this comment.
I guess we want AllowShortBlocksOnASingleLine: Always
| @@ -107,7 +107,8 @@ private slots: | |||
| result() | |||
| : inchikey("Error"), name("Error"), mol2url("Error"), formula("Error"), | |||
| mass(-1.0) | |||
| {} | |||
| { | |||
There was a problem hiding this comment.
These kind of changes seem really weird considering a bunch of other short blocks are consolidated.
If we can get rid of these, I'd appreciate it.
|
I'll have to look more carefully. Somewhere the |
|
Otherwise, most of this looks good. |
|
Okay, the |
Signed-off-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
change AllowShortBlocksOnASingleLine to Empty Signed-off-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
keep include order and revert sort Signed-off-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| unsigned char edgeCaseY = edgeCases[edgeCaseIdxY]; | ||
|
|
||
| // If the sum is odd, the edge along the y-axis is cut | ||
| if ((edgeCase + edgeCaseY) % 2 == 1) | ||
| { | ||
| if ((edgeCase + edgeCaseY) % 2 == 1) { |
Check warning
Code scanning / CodeQL
Bad check for oddness Warning
| unsigned char edgeCaseZ = edgeCases[edgeCaseIdxZ]; | ||
|
|
||
| // If the sum is odd, the edge along the z-axis is cut | ||
| if ((edgeCase + edgeCaseZ) % 2 == 1) | ||
| { | ||
| if ((edgeCase + edgeCaseZ) % 2 == 1) { |
Check warning
Code scanning / CodeQL
Bad check for oddness Warning
| // #ifdef __cplusplus | ||
| // extern "C" | ||
| //{ | ||
| //#endif /* __cplusplus */ | ||
| // #endif /* __cplusplus */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // #ifdef __cplusplus | ||
| // } /* extern "C" */ | ||
| // #endif /* __cplusplus */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
| /* | ||
| d->program.detachShader(d->vertexShader); | ||
| d->program.detachShader(d->fragmentShader); | ||
| d->vertexShader.cleanup(); | ||
| d->fragmentShader.cleanup(); | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.