Fix compiler crashes when instrumenting programs with nested Cilk contexts and nested reducers #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
neboat
commented
Jan 15, 2025
neboat
commented
- During loop-spawning avoid moving syncregions unnecessarily out of a taskframe added to the synthesized parallel divide-and-conquer routine. This change fixes Nested reducer causes Cilksan crash at runtime and compiler crash when building for Cilkscale #306
- Work around an issue when instrumenting a program simultaneously with Cilksan and ASan, where ASan's hooks are not inserted into spawned tasks with the correct exception-handling blocks.
… to avoid hosting syncregions used within a taskframe inserted by loop-spawning outside of that taskframe. Improve logic for finding external uses of taskframes to fixup.
…r CilkSanitizer instrumentation. If ASan inserts hooks into spawned tasks with other exception-handling logic, it either needs to mark that these hooks do not throw or it needs to invoke these hooks with unwinding blocks that connect with the unwind blocks of the enclosing task. ASan does not currently do this and instead inserts these hooks naively. This change works around ASan's behavior by marking that calls to ASan hook in spawned tasks do not throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.