Issue 336: Declare libcyphal transport interfaces #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `ITransport::makeMessage[Rx|Tx]Session` methods - added `ITransport::make[Request|Response][Rx|Tx]Session` methods Also: - added `libcyphal::UniquePtr` & `libcyphal::Expected` - added`transport::AnyError`
…essageRxTransfre` and `ServiceRxTransfer` types.
pavel-kirienko
requested changes
Apr 8, 2024
include/libcyphal/runnable.hpp
Outdated
Comment on lines
22
to
27
| IRunnable() = default; | ||
| IRunnable(const IRunnable&) = default; | ||
| IRunnable(IRunnable&&) = default; | ||
|
|
||
| IRunnable& operator=(const IRunnable&) = default; | ||
| IRunnable& operator=(IRunnable&&) = default; |
There was a problem hiding this comment.
I think runnables must be non-copyable, otherwise things like AggregateRunnable et all will break, because we have to be able to keep valid references to the interface. If the implementation object is moved, references lose validity.
pavel-kirienko
approved these changes
Apr 8, 2024
| IRunnable& operator=(IRunnable&&) = default; | ||
| IRunnable() = default; | ||
| IRunnable(IRunnable&&) = default; | ||
| IRunnable& operator=(IRunnable&&) = default; |
There was a problem hiding this comment.
future note: do not forget to update this in the next pr
| }; | ||
|
|
||
| // TODO: Maybe have `cetl::byte` polyfill for C++20 | ||
| using PayloadFragments = cetl::span<cetl::span<std::uint8_t>>; |
There was a problem hiding this comment.
will double check (next pr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITransport::makeMessage[Rx|Tx]SessionmethodsITransport::make[Request|Response][Rx|Tx]SessionmethodsPriority,[Service]TransferMetadata,PayloadFragments,MessageRxTransfreandServiceRxTransfertypes.transport::AnyErrorDynamicBuffer.Also:
libcyphal::UniquePtr&libcyphal::Expected