Stabilize uavcan.node.port.List

[pavel-kirienko]

Closes #134; the other v0 types can be stabilized after the release.

[pavel-kirienko]

@thirtytwobits nudge

[thirtytwobits]

Sorry... 👀

[pavel-kirienko]

It's a union, only one field is active at any moment. The empty field is just a tag.

…

On Thu, Feb 16, 2023, 03:23 Scott Dixon ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In uavcan/node/port/SubjectIDList.1.0.dsdl <#138 (comment)> : > +# A list of subject identifiers. +# The range of subject-ID is large, so using a fixed-size bitmask would make this type difficult to handle on +# resource-constrained systems. To address that, we provide two extra options: a simple variable-length list, +# and a special case that indicates that every subject-ID is in use. + ***@***.*** + +uint16 CAPACITY = SubjectID.1.0.MAX + 1 + +bool[CAPACITY] mask +# The index represents the identifier value. True -- present/used. False -- absent/unused. + +SubjectID.1.0[<256] sparse_list +# A list of identifiers that can be used instead of the mask if most of the identifiers are unused. + +uavcan.primitive.Empty.1.0 total Wait...how am I supposed t use this? ------------------------------ In uavcan/node/port/SubjectIDList.1.0.dsdl <#138 (comment)> : > @@ -0,0 +1,19 @@ +# A list of subject identifiers. +# The range of subject-ID is large, so using a fixed-size bitmask would make this type difficult to handle on +# resource-constrained systems. To address that, we provide two extra options: a simple variable-length list, +# and a special case that indicates that every subject-ID is in use. + ***@***.*** + +uint16 CAPACITY = SubjectID.1.0.MAX + 1 + +bool[CAPACITY] mask If I use the sparse_list am I required to also set the mask? There's a bit of ambiguity here on the requirements for using this type. — Reply to this email directly, view it on GitHub <#138 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFIZDJ2FMWISSXCSRTZLDWXV6QBANCNFSM6AAAAAAUYYTUJY> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[thirtytwobits]

It's a union, only one field is active at any moment. The empty field is just a tag.

I'm an idiot. Sorry.