Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement world.GetConfig and SetConfig for environment variables #817

Merged
merged 10 commits into from
Sep 28, 2022

Conversation

SpaceManiac
Copy link
Contributor

@SpaceManiac SpaceManiac commented Sep 25, 2022

"env" is implemented but "admin" and "ban" are not. Pursuant to #289 and #290.

To test those changes, the following test suite fixes were made:

  • Reset DMObjectTree.Globals between compilations so references to world are correct
  • Reset DreamManager.Globals between runs to match
  • Add runtime when dividing by zero; Const3.dm previously passed because of global confusion
  • Use relative paths to .dm files to make test explorer easier to read

@wixoaGit wixoaGit merged commit f3b3d34 into OpenDreamProject:master Sep 28, 2022
@SpaceManiac SpaceManiac deleted the patch/world-getconfig branch September 29, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants