-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix start/end date on Windows and enforce band order normalization #1701
Conversation
This PR also enforces band order normalization, relying on the We now enforce this band order:
Which is pretty common/standard. |
Perfect. Follows the wavelength order too. |
This will also improve multispectral alignment, because in cases where the manufacturer chose "RedEdge" as index 0, RedEdge was automatically chosen as the primary band (unless overriden via We now automatically favor RGB, or a Blue band if available, otherwise the first band in the list. |
Can we favor green over blue for alignment? That should be higher SNR than blue on these sensors. |
Sure! |
I don't know how to modify to test, but most sensors mimic human vision and green is the most responsive channel, plus slightly longer wavelength gives less noise on CCD and CMOS (blue is too close to UV), but not so long focusing and scatter becomes problematic (NIR/red-edge) So, it should be slightly better but I can't prove it out 😑 |
Fixes #1699