Added BG12 and expected csv file #1353
Merged
+139
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huss
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Thanks to @nicholasyfu1 for their first contribution to OED. Review and testing found it works as expected. I have made one small comment on a comment to remove. It should be straightforward to address.
huss
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Thanks to @nicholasyfu1 for quickly addressing the comment. This is ready to merge. Congratulations on your first accepted work for OED.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added BG12 test and expected csv file. Test passed when I ran it in the docker container.
Partly Addresses #962
Type of change
Checklist
Limitations