Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Translation Method #1354

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

lawsj
Copy link

@lawsj lawsj commented Oct 4, 2024

Description

Made changes to use the new "useTranslate()" instead of the old "translate()".

Partly Addresses #1204

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

##Limitations

N/a

@Rakesh-Ranga-Buram
Copy link
Contributor

Everything looks good to me. Please convert the draft to PR.

@Rakesh-Ranga-Buram
Copy link
Contributor

@huss , this PR only include changes related to translate() method and not formatMessage() method. Since formatMessage() changes are already been done on #1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants