Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rate help; notify if cannot graph; fix rate with area #965

Merged
merged 5 commits into from
Jul 14, 2023
Merged

rate help; notify if cannot graph; fix rate with area #965

merged 5 commits into from
Jul 14, 2023

Conversation

huss
Copy link
Member

@huss huss commented Jul 11, 2023

Description

This addresses several issues found during testing of proposed v1.0.0

  • The rate menu on line graphics lacked a help icon.
  • Unit help now has text.
  • Each graphic now shows a text message if there is no data or if you cannot graph due to raw data. This Fixes empty graphic #576 in a different way than originally discussed but it is a better solution since you don't see any graphic except for compare.
  • Fixes a bug where the rate menu had no impact if were normalizing by area.

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request

Limitations

Compare graphics still shows all the graphs for each item but the title indicates that you cannot do raw units. This is consistent with telling which ones have no current data but it probably would be nice to avoid all the graphs as is done when there is no meter/group selected. Not a common case since needs to be raw with several items so it can be done later.

huss added 3 commits July 8, 2023 16:51
@huss
add rate help; update unit help text
03b651e
@huss
notify user when cannot graph
2fe0318 
This makes raw tell user when cannot graph if not line. It also puts up
a message for empty graphics rather than a blank graph.
This addresses issue empty graphic OpenEnergyDashboard#576.
@huss
rate & area work together
f86670e 
This simplifies the logic and removes a bug where did not see rate on
line graphic if also did area. It now always normalizes but uses 1
if none or if rate is per hour.
@huss huss added this to the 1.0 Release milestone Jul 11, 2023
@huss huss requested a review from spearec July 11, 2023 21:41
spearec
spearec approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@spearec spearec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

For the bar and compare raw unit warnings, I think it might be better to say something along the lines of "cannot create bar graph for raw units" instead of "no bar for raw units."

@huss
Copy link
Member Author

huss commented Jul 14, 2023

For the bar and compare raw unit warnings, I think it might be better to say something along the lines of "cannot create bar graph for raw units" instead of "no bar for raw units."

Thanks. Agreed and done.

@huss
Copy link
Member Author

huss commented Jul 14, 2023

The review by @spearec is considered approving so this PR is now ready to merge.

@huss huss merged commit 3e2252b into OpenEnergyDashboard:development Jul 14, 2023
3 checks passed
@huss huss mentioned this pull request Jul 15, 2023
Closed
5 tasks
@huss huss deleted the graphIssues branch September 1, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spearec spearec spearec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 Release
Development

Successfully merging this pull request may close these issues.

empty graphic
2 participants
@huss @spearec