Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement oekg predicates #2020

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

madbkr
Copy link
Contributor

@madbkr madbkr commented Feb 17, 2025

Summary of the discussion

As discussed in #2013 we need some more predicates to use in the OEKG. Some of those are implemented here as discussed in the issue.

Type of change (CHANGELOG.md)

Add

  • has iri, has study descriptor tag, has uuid, has scenario type, has publication date, has report title, has doi, has reference, based on sector division

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-model changes the oeo-model module label Feb 17, 2025
@madbkr madbkr self-assigned this Feb 17, 2025
@madbkr madbkr marked this pull request as ready for review February 17, 2025 15:16
@madbkr madbkr requested a review from stap-m February 17, 2025 15:16
Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My remarks on has number and object property vs data property seem to apply to more than has iri.

<http://purl.obolibrary.org/obo/IAO_0000027> or <http://purl.obolibrary.org/obo/IAO_0000310>

Range:
OEO_00140178 some rdfs:Literal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OEO_00140178 some rdfs:Literal
OEO_00140178 some rdfs:Literal

why has number? A literal can also be a string... https://www.w3.org/TR/rdf-schema/#ch_literal

I have the impression that has iri should be a data property itself. Like this, the range could be rdfs:literal directly.

OEO_00020227

Range:
OEO_00140178 some rdfs:Literal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need a new data property for that. Has literal value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-shared-axioms
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

2 participants