tests: fix linked list leaks #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesKauffmann
changed the title
JohannesKauffmann
changed the title
JohannesKauffmann
force-pushed
the
fix-simple_ng-leak
branch
from
d14e935 to
955655d
Compare
JohannesKauffmann
force-pushed
the
fix-simple_ng-leak
branch
from
955655d to
99e7586
Compare
|
ping @ArthurKetels @nakarlsson |
hefloryd
reviewed
Mar 11, 2025
JohannesKauffmann
force-pushed
the
fix-simple_ng-leak
branch
from
99e7586 to
e912fa9
Compare
Don't overwrite the original pointer returned by ec_find_adapters(), otherwise the linked list is leaked. Instead, save original pointer to the head of the list use and `adapters` as a temporary variable. Pass the original pointer to ec_free_adapters(). For win32, ec_free_adapters() was missing entirely.
JohannesKauffmann
force-pushed
the
fix-simple_ng-leak
branch
from
e912fa9 to
daed60a
Compare
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't overwrite the original pointer returned by ec_find_adapters(), otherwise the linked list is leaked. Instead, save original pointer to the head of the list use and
adaptersas a temporary variable. Pass the original pointer to ec_free_adapters().For win32, ec_free_adapters() was missing entirely.