Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test test_charge_transformer #111

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Feb 20, 2025

This test just started to fail without any code changes:

image

env diff:

11c11
< beautifulsoup4                 4.13.0              pyha770c72_0                       conda-forge
---
> beautifulsoup4                 4.13.1              pyha770c72_0                       conda-forge
54c54
< h2                             4.1.0               pyhd8ed1ab_1                       conda-forge
---
> h2                             4.2.0               pyhd8ed1ab_0                       conda-forge
205c205
< reportlab                      4.2.5               py311h9ecbd09_0                    conda-forge
---
> reportlab                      4.3.0               py311h9ecbd09_0                    conda-forge
210c210
< scikit_mol                     0.4.5               pypi_0                             pypi       
---
> scikit-mol                     0.4.6               pypi_0                             pypi       
246c246
< xorg-libx11                    1.8.10              h4f16b4b_1                         conda-forge
---
> xorg-libx11                    1.8.11              h4f16b4b_0                         conda-forge

@mikemhenry
Copy link
Contributor Author

Looks like this is the change:
EBjerrum/scikit-mol#58

I can fix the conda-forge package by adding a pin, but then we need to make a new release and update the API

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.87%. Comparing base (542652a) to head (0bddf03).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   87.87%   87.87%           
=======================================
  Files          49       49           
  Lines        1559     1559           
=======================================
  Hits         1370     1370           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor Author

Okay that fixes it!

Copy link
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@mikemhenry mikemhenry merged commit 4979e18 into main Feb 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants