Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin rdkit to 2024.03.5 #88

Merged
merged 1 commit into from
Oct 28, 2024
Merged

pin rdkit to 2024.03.5 #88

merged 1 commit into from
Oct 28, 2024

Conversation

atravitz
Copy link
Contributor

This pins us to a version pre-rdkit bug. Their latest release has this fixed as well, but has some conflicts with our other dependencies that are not immediately resolvable.

@atravitz atravitz requested a review from RiesBen October 25, 2024 21:10
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (474e1f9) to head (b70875f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          49       49           
  Lines        1577     1577           
=======================================
  Hits         1369     1369           
  Misses        208      208           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atravitz atravitz requested a review from mikemhenry October 25, 2024 21:58
@atravitz atravitz marked this pull request as ready for review October 28, 2024 17:29
@mikemhenry mikemhenry merged commit 8c62d86 into main Oct 28, 2024
6 checks passed
atravitz added a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants