Utility function changes for protein mutations #1106
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijpulidos
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
- Coverage 93.52% 92.68% -0.85%
==========================================
Files 142 141 -1
Lines 10628 10795 +167
==========================================
+ Hits 9940 10005 +65
- Misses 688 790 +102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
reviewed
Jun 17, 2025
| solvent_comps = list(set(solvent_comps)) # if given iterable | ||
| except TypeError: | ||
| solvent_comps = [solvent_comps] # if not iterable, given single obj | ||
| # TODO: Support multiple solvent components? Is there a use case for it? |
Member
There was a problem hiding this comment.
Probably not - it doesn't really mean much in the current SolventCOmponent structure.
Contributor
Author
There was a problem hiding this comment.
Yes, I agree with that. But I guess it doesn't hurt to have the TODO there? Unless you find it annoying, we can remove it.
|
No API break detected ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial preliminary support for protein mutation setup on
feflowChecklist
newsentryDevelopers certificate of origin