Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more params to dapr pubsub subscription #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

halegreen
Copy link

@halegreen halegreen commented Jul 23, 2022

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -331,6 +332,12 @@ type TracingProvider struct {
OapServer string `json:"oapServer" yaml:"oapServer"`
}

type PubSubRoutingRule struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not define the router, match, and priority directly into the input?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think it is more clear to group router, match, priority to the one struct PubSubRoutingRule, other than put them directly into the input

considering every prop. Uri, ComponentName, ComponentType, Metadata maybe different for different trigger,
of input in function context

type Input struct {
	Uri               string             `json:"uri,omitempty"`
	ComponentName     string             `json:"componentName"`
	ComponentType     string             `json:"componentType"`
	Metadata          map[string]string  `json:"metadata,omitempty"`
}

@halegreen
Copy link
Author

@tpiperatgod @wrongerror hi , any suggestions on this pr?

@benjaminhuo
Copy link
Member

See my comments in OpenFunction/OpenFunction#332

@halegreen
Copy link
Author

See my comments in OpenFunction/OpenFunction#332

fixed it . please have a look.

@wanjunlei
Copy link
Member

wanjunlei commented Feb 20, 2023

See my comments in OpenFunction/OpenFunction#332

fixed it . please have a look.

Please make sure this pr does not conflict with #66, they both set the route.

@benjaminhuo
Copy link
Member

benjaminhuo commented Feb 23, 2023

See my comments in OpenFunction/OpenFunction#332

fixed it . please have a look.

Looks like still not fixed OpenFunction/OpenFunction#332 (comment):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants