Adds Gradle build that delegates to existing Ant build #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoPiel
force-pushed
the
feature/gradle-build-ant
branch
from
16b7bae to
fb1c8ab
Compare
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Adds a top-level Gradle build that imports the existing Ant build to enable a gradual migration to Gradle while still using Ant for current tasks. Configures Ant to run JUnit (including ant-junit4) and exposes select Gradle properties to Ant; renames conflicting Ant targets to avoid collisions and makes the Gradle build task delegate to the Ant build target. Also adds placeholder Gradle files for subprojects and bumps the configured Gradle SDK version. Co-authored-by: Mitch Gaffigan <mitch.gaffigan@comcast.net> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
force-pushed
the
feature/gradle-build-ant
branch
from
6a6e3c7 to
ddf0ada
Compare
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
mgaffigan
requested changes
Dec 1, 2025
Contributor
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
Other issues to address
- CI build scripts need updated (.github/workflow/...)
- Readme/Contributor documents need updated
- ant mirth-build build target needs to be updated to block build outside of gradle with migration guidance in error message
Comment on lines
+46
to
+53
| // Pass Gradle properties to Ant | ||
| project.findProperty("disableSigning")?.let { | ||
| ant.properties["disableSigning"] = it.toString() | ||
| } | ||
|
|
||
| project.findProperty("disableTests")?.let { | ||
| ant.properties["disableTests"] = it.toString() | ||
| } |
Contributor
There was a problem hiding this comment.
Are there other properties we need to be passing?
Contributor
Author
There was a problem hiding this comment.
Good question. I'm not sure. These are the only two I use and the only two available in mirth-build.xml, afaia.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initial Gradle build system that delegates to the existing Ant build to enable gradual migration and tooling improvements.
Highlights:
Why:
Notes / Next steps: