Maintain consistent element order in exports #45
Conversation
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
rogin
force-pushed
the
maint-element-order-exports
branch
from
c944e16 to
8630dde
Compare
| package com.mirth.connect.donkey.model.message; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.TreeMap; |
There was a problem hiding this comment.
Since a TreeMap is sorted and a HashMap is not, I'm guessing there could be considerable changes compared to a prior export the first time an export is done with the new code?
There was a problem hiding this comment.
Correct, then subsequent exports will benefit.
There was a problem hiding this comment.
Is there a purpose for having MapContent as part of this PR? I think it only shows up in a message export, and not part of the server configuration?
There was a problem hiding this comment.
I'll revert it and verify.
server/src/com/mirth/connect/model/converters/MapContentConverter.java
Outdated
Show resolved
Hide resolved
rogin
dismissed stale reviews from kpalang, gibson9583, and jonbartels
via
7162f41
|
Can you describe your testing? I'm sure this does work when creating and exporting new code templates and libraries. Do we know for certain that when xstream creates the objects from xml that it isn't recreating them as HashSets? |
jonbartels
added
enhancement
5 participants
Fixes an old and common complaint. Previous test results here. I've only verified that it built successfully using Java 8.
Testing points:
diff) are improved with consistent order