Install4j configuration #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayyagari
requested review from
gibson9583,
jonbartels,
kpalang,
pacmano1,
ssrowe and
tonygermano
Author
|
The generated installers:
|
jonbartels
requested changes
May 20, 2025
tonygermano
requested changes
May 22, 2025
kayyagari
force-pushed
the
feature/install4j-config-81
branch
from
684bbb8 to
7247f5b
Compare
tonygermano
force-pushed
the
feature/install4j-config-81
branch
from
31822b8 to
e3ccc72
Compare
Co-authored-by: Paul Coyne <44065187+pacmano1@users.noreply.github.com> Signed-off-by: kayyagari <kiran@sereen.io> Signed-off-by: Tony Germano <tony@germano.name> Issue: #81
tonygermano
force-pushed
the
feature/install4j-config-81
branch
from
e3ccc72 to
75ca77c
Compare
tonygermano
approved these changes
Jun 28, 2025
jonbartels
approved these changes
Jun 28, 2025
pacmano1
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have commented out the line that included modules to make the binary start with Java8 by default(because our first release still targets Java8) , let me know if there are any objection to that.