Gen feat build file fix #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
turkeylurkey
approved these changes
Feb 2, 2022
TrevCraw
reviewed
Feb 2, 2022
src/main/groovy/io/openliberty/tools/gradle/tasks/DevTask.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
kathrynkodama
force-pushed
the
genFeat-build-file-fix
branch
from
615c957
to
ec1509f
Compare
|
Updated the logic to detect dependency changes in the build.gradle, and run Tried to add a new integration test to cover this case, but altering the build.gradle through the integration tests results in the following error Opened a separate issue: #708 |
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
TrevCraw
reviewed
Feb 8, 2022
src/main/groovy/io/openliberty/tools/gradle/tasks/DevTask.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/io/openliberty/tools/gradle/tasks/DevTask.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
…dev mode already Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
kathrynkodama
force-pushed
the
genFeat-build-file-fix
branch
from
a39580d
to
9228dfd
Compare
TrevCraw
reviewed
Feb 9, 2022
TrevCraw
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a build file dependency change is detected, add an additional check to only call generateFeatures if there are class files to generate for.
Also include a minor improvement to the clean up logic in the dev integration tests.
See OpenLiberty/ci.maven#1409