Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1006] Upgraded LCLS version to 2.2 #1052

Closed
wants to merge 5 commits into from
Closed

[#1006] Upgraded LCLS version to 2.2 #1052

wants to merge 5 commits into from

Conversation

dessina-devasia
Copy link
Contributor

@dessina-devasia dessina-devasia commented Oct 24, 2024 •
edited
Loading

Fixes #1006
Upgraded LCLS version to 2.2

turkeylurkey
turkeylurkey previously approved these changes Oct 24, 2024
View reviewed changes
TrevCraw
TrevCraw requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that LCLS has been released, let's go ahead and bump to the release version 2.2

@dessina-devasia dessina-devasia changed the title Fixes #1006: Upgraded LCLS version to 2.2-SNAPSHOT [#1006] Upgraded LCLS version to 2.2-SNAPSHOT Oct 28, 2024
@dessina-devasia dessina-devasia changed the title [#1006] Upgraded LCLS version to 2.2-SNAPSHOT [#1006] Upgraded LCLS version to 2.2 Oct 28, 2024
turkeylurkey
turkeylurkey requested changes Oct 28, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@TrevCraw
Copy link
Contributor

Hi @dessina-devasia , ultimately the only commit we need is fe4a81d. To clean up the commit history, would you be able to rebase your branch off of main and select that one commit or create a new branch and make this one change?

@turkeylurkey
Copy link
Member

I like git rebase -i main because it brings up an editor and you can squash commits etc.

@dessina-devasia
Copy link
Contributor Author

Opened a similar PR #1055

@dessina-devasia dessina-devasia deleted the 1006-support-latest-lcls branch October 29, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkeylurkey turkeylurkey turkeylurkey approved these changes

@aparnamichael aparnamichael Awaiting requested review from aparnamichael

@TrevCraw TrevCraw Awaiting requested review from TrevCraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the latest release of LCLS (Q4-2024)
4 participants
@dessina-devasia @TrevCraw @turkeylurkey @mrglavas