Add environment variable to set the timeout when starting dev mode Liberty for debugging #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
turkeylurkey
force-pushed
the
issue-1060
branch
from
20a905f
to
d86c012
Compare
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
mrglavas
approved these changes
Oct 31, 2024
TrevCraw
approved these changes
Oct 31, 2024
turkeylurkey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1060
The default value is 3 minutes. This was chosen because Gradle can be slow to start. On github action machines it can take 4-5 minutes to start Liberty dev mode. So we added an environment variable to allow us to specify a longer timeout when testing. The timeout when testing is 8 minutes.