Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication in AnnotationDiagnosticsCollector.collectDiagnostics(). #1069

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

mrglavas
Copy link
Contributor

@mrglavas mrglavas commented Nov 1, 2024

Resolves #1068

Refactored annotation processing loops into one method as well as making some arrays into constants.

Signed-off-by: Michael Glavassevich <mrglavas@ca.ibm.com>
…hould be constants.

Signed-off-by: Michael Glavassevich <mrglavas@ca.ibm.com>
Signed-off-by: Michael Glavassevich <mrglavas@ca.ibm.com>
@mrglavas mrglavas self-assigned this Nov 1, 2024
@mrglavas mrglavas marked this pull request as draft November 1, 2024 18:27
@mrglavas mrglavas marked this pull request as ready for review November 1, 2024 18:51
Copy link
Contributor

@aparnamichael aparnamichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@mrglavas mrglavas merged commit 3e3c97c into OpenLiberty:main Nov 8, 2024
3 checks passed
@mrglavas mrglavas deleted the 1068#reduce-code-duplication branch November 8, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce code duplication in AnnotationDiagnosticsCollector.collectDiagnostics().
3 participants