Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #198 Added code to shift focus to the terminal #503

Conversation

vaisakhkannan
Copy link
Contributor

@vaisakhkannan vaisakhkannan commented Sep 22, 2023

Part of #198
Added code to shift focus to the terminal

@vaisakhkannan
Copy link
Contributor Author

vaisakhkannan commented Sep 26, 2023

I added some code in LibertyProjectUtil.java. It's actually working, but there are two exceptional cases:

  1. If two projects have the same name, let's say "example" and I perform a Liberty action, it will open a terminal window named "example". If I then perform a Liberty action in another project with the same name, "example," it will open a terminal session named "example (1)". However, when I attempt to perform a Liberty action on the "example (1)" project, the focus always reverts to the "example" project. Issue opened to address this here: Improper Terminal focus configuration for a project with the same name #505

(Note: Both project names in the Liberty dashboard remain as "example")

  1. When I open the project “guide-getting-started", the terminal tab name gets stripped, and the terminal window name appears as 'guide-get…ng-started' .When I check the condition "widgetName.equals(displayName)", it fails. The reason behind this failure is that the widgetName is 'guide-getting-started' and the displayName is 'guide-get…ng-started' , so they don't match. This mismatch causes the focus to shift to the Local tab named terminal session. Issue opened to address this here: Improper Terminal focus configuration for a project with the long project name #506

@TrevCraw TrevCraw changed the title Fixes #198 Added code to shift focus to the terminal Part of #198 Added code to shift focus to the terminal Jan 18, 2024
@vaisakhkannan vaisakhkannan marked this pull request as draft February 2, 2024 05:01
@vaisakhkannan
Copy link
Contributor Author

Closing this pull request since the original pull request at #637 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants