Fixes #512 - Transform the Quick Fixes which extends InsertAnnotationQuickFix to implement the code action participant extension point #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Trevor Crawford <TrevCraw@users.noreply.github.com>
…er/ProcessStreamConnectionProvider.java Co-authored-by: Trevor Crawford <TrevCraw@users.noreply.github.com>
The server files were modified. changed to built in IntelliJ APIs to show pop up errors.
checkJavaHome() made to return a boolean value. and modified the code according to other comments
added the boolean return method
Formatting done. Changed method name to isJavaHomeValid.
…Liberty#196 Fixes OpenLiberty#196 : Error message popup if Java 17 is not found to launch language servers
1. Implemented IJavaCodeActionParticipant 2. Made the class abstract
…ngType quick fix Added extension point and enabled the tests
aparnamichael
requested review from
mrglavas,
vaisakhkannan and
dessina-devasia
dessina-devasia
approved these changes
Oct 9, 2023
aparnamichael
commented
Oct 9, 2023
| @@ -112,4 +131,16 @@ protected PsiModifierListOwner getBinding(PsiElement node) { | |||
| protected String getLabel(String annotationName, String... attributes) { | |||
| return Messages.getMessage("InsertItem", "@" + annotation); // uses Java syntax | |||
| } | |||
|
|
|||
| private CodeAction createCodeAction(JavaCodeActionContext context, Diagnostic diagnostic, String label) { | |||
There was a problem hiding this comment.
@mrglavas - can we raise a separate PR for moving this method to a common file?
There was a problem hiding this comment.
@aparnamichael Yes. Feel free to open a separate issue and PR for this. Thanks.
There was a problem hiding this comment.
Created PR for the same - #531
…nsertAnnotationQuickFix
mrglavas
approved these changes
Oct 17, 2023
aparnamichael
merged commit 4ac1934
into
OpenLiberty:code-action-unification
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512 - Transform the Quick Fixes which extends InsertAnnotationQuickFix to implement the code action participant extension point
Enabled code actions test as well