Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #222 add hover info to entries in the Liberty Tool window #528

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Fixes #222 add hover info to entries in the Liberty Tool window #528

wants to merge 6 commits into from

Conversation

Rahul-Biju
Copy link
Contributor

Fixes #222 Added hover info to entries in the Liberty Tool window

@TrevCraw TrevCraw self-requested a review October 20, 2023 06:01
aparnamichael
aparnamichael previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@aparnamichael aparnamichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

TrevCraw
TrevCraw requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out the behaviour and noticed something that needs to be updated. My mouse was nowhere near the project in the Liberty dashboard, but the hover text appeared. The white circle in the image below is roughly where my mouse was when the pop up text appeared. We should only be displaying the pop up text when hovering over the project element in the tree.
image

TrevCraw
TrevCraw requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@TrevCraw TrevCraw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip text covers up the Liberty actions and other project nodes when moving the mouse off of the project node. This should be addressed before merging these changes.

liberty-project-hover-behaviour.mp4

@TrevCraw TrevCraw marked this pull request as draft May 6, 2024 16:31
@TrevCraw TrevCraw mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevCraw TrevCraw TrevCraw requested changes

@aparnamichael aparnamichael aparnamichael left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hover info to entries in the Liberty Tool window
3 participants
@Rahul-Biju @TrevCraw @aparnamichael