Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if an object is a LibertyModuleNode before trying to cast it. #562

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

turkeylurkey
Copy link
Member

Fixes #561

Hopefully by avoiding the ClassCastException the IntelliJ framework can continue to render projects and it will not allow the project to disappear and reappear in the projects view. I was not able to reproduce the project disappear/reappear bug,

Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
@turkeylurkey turkeylurkey self-assigned this Nov 3, 2023
@turkeylurkey
Copy link
Member Author

Linux test failure

ERROR: 2023-11-04T05:32:27.924780275: testStartInContainerActionUsingSearch:validateLibertyServerStopped: Exit. Timed out waiting for message CWWKE0036I in log:/home/runner/work/liberty-tools-intellij/liberty-tools-intellij/liberty-tools-intellij/src/test/resources/projects/gradle/singleModGradleMP/build/wlp/usr/servers/defaultServer/logs/messages.log

then

ERROR: 2023-11-04T05:38:56.912080841: testStartWithConfigInDebugModeUsingToolbar:validateProjectStarted: Timed out while waiting for project with resource URI api/resourceand port 9080 to become available.

@turkeylurkey turkeylurkey merged commit d70cf24 into OpenLiberty:main Nov 6, 2023
2 of 3 checks passed
@turkeylurkey turkeylurkey deleted the issue-561 branch November 6, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCastException when an unexpected pom file is found.
3 participants