Workaround Fix for Server.env Diagnostic and Popup Not Appearing Issue #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For Reference: https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11045391029 There are no builds failing due to the mentioned issue, so this workaround is acceptable for now to achieve green builds. |
src/test/java/io/openliberty/tools/intellij/it/SingleModLibertyLSTestCommon.java
Outdated
Show resolved
Hide resolved
TrevCraw
requested changes
Oct 12, 2024
src/test/java/io/openliberty/tools/intellij/it/SingleModLibertyLSTestCommon.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trevor Crawford <TrevCraw@users.noreply.github.com>
aparnamichael
approved these changes
Oct 14, 2024
|
Since we are getting close to a fix for redhat-developer/lsp4ij#577, we may not need this workaround. |
|
No longer need this workaround, since we have these two fixes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a workaround for this issue #945, the team has agreed to try
closing and reopening server.envafter inserting the invalid value 'NONE'.We need to ensure the underlying issue is resolved in the future, and the workaround added in the PR should be removed at that time.
NOTE: I observed that there is no issue in the
server.envfiles for version0.3.0(for all builds), but I found that the 'diagnostic not appearing' error leads to the 'hover not present' error in the server.env files for versions0.4.0and0.5.0(for all builds). Aparna also confirmed that the same issue is present in version 0.6.0 as well