Support collection of remote logging data in testify #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
from
4a03e74
to
4a4a937
Compare
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
from
fd10775
to
fabbab7
Compare
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
from
4f9d83c
to
fba8ddb
Compare
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
4 times, most recently
from
05f53b3
to
799b926
Compare
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
from
1f8e6dc
to
35d94b0
Compare
joe-chacko
changed the title
habiblawal1
previously approved these changes
Jul 6, 2023
ngmr
reviewed
Jul 6, 2023
testify/src/main/java/testify/annotation/logging/LogRecorder.java
Outdated
Show resolved
Hide resolved
ngmr
reviewed
Jul 6, 2023
ngmr
reviewed
Jul 6, 2023
ngmr
reviewed
Jul 6, 2023
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
2 times, most recently
from
effb27e
to
b0f2085
Compare
Test PartRunner function. Rename TestPart to Part. Allow Part chaining with andThen() and butFirst(). Distinguish join hooks (local to parent) from jvm hooks (local to child). Add state machine to PartRunner.
Rename LoggingController to LogPublisher Move LogSetting to a top-level class Allow empty keys and values on InterProcessBus Add new TypeSpecs for Integer, List<String> and List<T>
Moved TypeSpec children to separate package Synchronised LogPublisher and LogRecorder Used dispatch-request-and-await-reply mechanics for LogRecorder comms Use separate, synchronous flow for initial log settings, then push new settings as they arrive Reverse order when popping settings and when closing LogRecorders Send formatter object when requesting log records Use keep-alive thread to keep log recorders available in remote JVMs Add method to check whether in a child process Added equals() and hashCode() to bus implementations Improved haiku comment by adding kigo and kireji
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
from
5d28dc8
to
372d1df
Compare
joe-chacko
commented
Jul 10, 2023
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
from
372d1df
to
7847e18
Compare
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
from
38eb742
to
e939527
Compare
joe-chacko
force-pushed
the
use-inter-process-for-obv-tests
branch
from
e939527
to
739aa01
Compare
habiblawal1
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.