Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Java build using correct Autotools env var (closes #1883) #1885

Conversation

DaAwesomeP
Copy link
Member

This supersedes #1883 and solves the issue found in #1881.

Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to try and fix the codespell typos too?

.github/workflows/build.yaml Outdated Show resolved Hide resolved
@peternewman
Copy link
Member

The distcheck is failing, it looks because this isn't in 0.10, so it might be easiest to just skip testing the Java stuff on 0.10, but the new distcheck stuff can then go into master too, where Java should build, or might need the Java updates from #1882 :
https://github.com/OpenLightingProject/ola/pull/702/files

DaAwesomeP and others added 2 commits July 27, 2023 10:14
@DaAwesomeP
Copy link
Member Author

Do you want to try and fix the codespell typos too?

See #1886.

The distcheck is failing, it looks because this isn't in 0.10, so it might be easiest to just skip testing the Java stuff on 0.10, but the new distcheck stuff can then go into master too, where Java should build, or might need the Java updates from #1882 : https://github.com/OpenLightingProject/ola/pull/702/files

OK, I modified this to fix the distcheck stuff but disable Java for now. Your following pull can re-enable it.

@DaAwesomeP
Copy link
Member Author

@peternewman polite ping!

Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@peternewman peternewman merged commit 9aceea7 into OpenLightingProject:0.10 Aug 9, 2023
22 checks passed
@peternewman peternewman added this to the 0.10.10 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants