Rename TAS to velocity in GASP-based phases #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crecine
reviewed
Jan 30, 2024
crecine
approved these changes
Jan 31, 2024
ehariton
reviewed
Feb 6, 2024
| @@ -32,14 +32,16 @@ def setup(self): | |||
| val=np.ones(nn), | |||
| desc=Dynamic.Mission.DRAG, | |||
| units="lbf") | |||
| self.add_input("TAS", val=np.ones(nn), desc="true air speed", units="ft/s") | |||
| self.add_input(Dynamic.Mission.VELOCITY, val=np.ones(nn), | |||
| desc="true air speed", units="ft/s") | |||
There was a problem hiding this comment.
desc should be updated to Velocity for this and VELOCITY_RATE line 44
ehariton
reviewed
Feb 6, 2024
| @@ -153,8 +153,8 @@ def setup(self): | |||
| promotes_inputs=[ | |||
| (Dynamic.Mission.SPECIFIC_ENERGY_RATE, | |||
| Dynamic.Mission.SPECIFIC_ENERGY_RATE_EXCESS), | |||
| (Dynamic.Mission.VELOCITY_RATE, "TAS_rate"), | |||
| (Dynamic.Mission.VELOCITY, "TAS")], | |||
| (Dynamic.Mission.VELOCITY_RATE, Dynamic.Mission.VELOCITY_RATE), | |||
There was a problem hiding this comment.
Don't need the aliasing here :)
ehariton
reviewed
Feb 6, 2024
| @@ -56,7 +57,7 @@ def setup(self): | |||
| add_aviary_input(self, Dynamic.Mission.ALTITUDE, val=np.ones(nn), units="ft") | |||
| add_aviary_input(self, Dynamic.Mission.DISTANCE, val=np.ones(nn), units="ft") | |||
|
|
|||
| self.add_output("TAS_rate", val=np.ones(nn), desc="TAS rate", units="ft/s**2", | |||
| self.add_output(Dynamic.Mission.VELOCITY_RATE, val=np.ones(nn), desc="TAS rate", units="ft/s**2", | |||
| tags=['dymos.state_rate_source:TAS', 'dymos.state_units:kn']) | |||
There was a problem hiding this comment.
This tag looks wrong now. it's referring to dymos.state_rate_source:TAS, but we're actually calling it Velocity_rate now. Not sure if this will brick something later.
ehariton
reviewed
Feb 6, 2024
aviary/mission/gasp_based/ode/unsteady_solved/test/test_unsteady_solved_ode.py
Show resolved
Hide resolved
ehariton
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renamed TAS to velocity in GASP-based phases.
Also refactored some time settings and phase instantiation so now
height_energyandtwo_dofshare more code.Related Issues
Backwards incompatibilities
None
New Dependencies
None