Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a CLI for users to download models #122

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Added a CLI for users to download models #122

merged 7 commits into from
Jan 31, 2024

Conversation

crecine
Copy link
Contributor

@crecine crecine commented Jan 30, 2024

Summary

Allows users that pip installed Aviary to download example models

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

johnjasa
johnjasa requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@johnjasa johnjasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun stuff, great implementation, I love the docs and tests, thank you! Got it working well locally and enjoy it. Few quick notes and suggestions.

aviary/docs/user_guide/aviary_commands.ipynb Outdated Show resolved Hide resolved
aviary/docs/user_guide/aviary_commands.ipynb Outdated Show resolved Hide resolved
aviary/interface/download_models.py Outdated Show resolved Hide resolved
johnjasa
johnjasa approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@johnjasa johnjasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update!

jkirk5
jkirk5 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice tests!

aviary/docs/user_guide/aviary_commands.ipynb Show resolved Hide resolved
@crecine crecine enabled auto-merge January 31, 2024 17:44
@crecine crecine added this pull request to the merge queue Jan 31, 2024
Merged via the queue into OpenMDAO:main with commit c86f157 Jan 31, 2024
7 checks passed
@crecine crecine deleted the download-models branch February 7, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkirk5 jkirk5 jkirk5 approved these changes

@johnjasa johnjasa johnjasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crecine @johnjasa @jkirk5