Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hamilton Standard model based on Jeff's enhancement #184

Merged
merged 25 commits into from
Mar 21, 2024

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Mar 18, 2024

Summary

  1. Enhanced Hamilton Standard model. The original Hamilton Standard model sometimes fails to work for high blade integrated lift coefficient (CLI). A few tables are modified; lower limit on equivalent power coefficient (CPE) for interpolation warning; allow 10 iterations (instead of 5) for the Newton-Rhapson method to find the corresponding equivalent thrust coefficient (CTE).
  2. In GAST, the "Warning" messages are suppressed for flight idle power calculations but this is not implemented in Aviary.
  3. A unit test for high CLI is added. The checking of partial derivative of 'comp_tip_loss_factor' with respect to 'aircraft:engine:propeller_integrated_lift_coefficient' is skipped because the calc mag. is 0.0 and the calc mag. is very close to zero (1.1102e-10). As a result, r(cal-chk) is always 1.0.
  4. Updated true values from GASP by increasing numerical significance of prop_eff and install_eff.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang requested review from johnjasa and crecine March 18, 2024 22:23
@xjjiang xjjiang marked this pull request as draft March 18, 2024 22:25
@xjjiang
Copy link
Contributor Author

xjjiang commented Mar 18, 2024

I will wait for John's PR #183 to merge into main.

@xjjiang xjjiang marked this pull request as ready for review March 20, 2024 19:42
Copy link
Member

@johnjasa johnjasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, nice catch with the variable metadata fix for prop tip speed!

@crecine crecine added this pull request to the merge queue Mar 21, 2024
Merged via the queue into OpenMDAO:main with commit bed0a1c Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants