Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adding notification for PR reviews" #188

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

crecine
Copy link
Contributor

@crecine crecine commented Mar 20, 2024

Reverts #185
pull-request-review runs in the forked repository, not the main repository, so it does not have access to the necessary secrets.

We could setup a workaround if desired.
https://stackoverflow.com/questions/67247752/how-to-use-secret-in-pull-request-review-similar-to-pull-request-target

@johnjasa johnjasa merged commit 9297439 into main Mar 21, 2024
12 checks passed
@crecine crecine deleted the revert-185-send_pr_approval branch April 3, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants