EngineDecks now take scale factor as an input#565
Merged
jkirk5 merged 19 commits intoOpenMDAO:mainfrom Jan 29, 2025
Merged
Conversation
Cleanup for N3CC data fle
Kenneth-T-Moore
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flipped engine sizing so scale factor is and input and target (scaled) thrust is an output, to better match how alternative propulsion systems are handled (such as motors)
Some light cleanup of FLOPS-based model data files to make it easer to determine what values are being set for each input
Related Issues
Backwards incompatibilities
None
New Dependencies
None