Skip to content

Test FLOPS Aero Builder #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Feb 25, 2025
Merged

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Dec 5, 2024

Summary

Added a unit test file for FLOPS based aerodynamic builder (20 unit tests).

Note: the unit test file for GASP based aerodynamic builder has to be put on hold because it depends on the consistency of default values in several GASP based components.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang changed the title Test flops aero builder Test FLOPS Aero Builder Dec 5, 2024
Copy link
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could use a second opinion on the use of _unspecified from another reviewer

@jkirk5 jkirk5 enabled auto-merge February 11, 2025 23:25
@xjjiang
Copy link
Contributor Author

xjjiang commented Feb 15, 2025

On line 469 here:

https://github.com/xjjiang/om-Aviary/blob/test_flops_aero_builder/aviary/subsystems/aerodynamics/aerodynamics_builder.py#L469

If I add 'units': units, I get the following errors:

   'traj.phases.climb' <class Phase>: Output units of 'unitless' for 'traj.phases.climb.param_comp.parameter_vals:aircraft:nacelle:characteristic_length' are incompatible with input units of 'ft' for 'traj.phases.climb.rhs_all.solver_sub.core_aerodynamics.Mux.aircraft:nacelle:characteristic_length'.
   'traj.phases.climb' <class Phase>: Output units of 'unitless' for 'traj.phases.climb.param_comp.parameter_vals:aircraft:nacelle:wetted_area' are incompatible with input units of 'ft**2' for 'traj.phases.climb.rhs_all.solver_sub.core_aerodynamics.Mux.aircraft:nacelle:wetted_area'.
   'traj.phases.cruise' <class Phase>: Output units of 'unitless' for 'traj.phases.cruise.param_comp.parameter_vals:aircraft:nacelle:characteristic_length' are incompatible with input units of 'ft' for 'traj.phases.cruise.rhs_all.solver_sub.core_aerodynamics.Mux.aircraft:nacelle:characteristic_length'.
   'traj.phases.cruise' <class Phase>: Output units of 'unitless' for 'traj.phases.cruise.param_comp.parameter_vals:aircraft:nacelle:wetted_area' are incompatible with input units of 'ft**2' for 'traj.phases.cruise.rhs_all.solver_sub.core_aerodynamics.Mux.aircraft:nacelle:wetted_area'.
   'traj.phases.descent' <class Phase>: Output units of 'unitless' for 'traj.phases.descent.param_comp.parameter_vals:aircraft:nacelle:characteristic_length' are incompatible with input units of 'ft' for 'traj.phases.descent.rhs_all.solver_sub.core_aerodynamics.Mux.aircraft:nacelle:characteristic_length'.
   'traj.phases.descent' <class Phase>: Output units of 'unitless' for 'traj.phases.descent.param_comp.parameter_vals:aircraft:nacelle:wetted_area' are incompatible with input units of 'ft**2' for 'traj.phases.descent.rhs_all.solver_sub.core_aerodynamics.Mux.aircraft:nacelle:wetted_area'.
   <model> <class AviaryGroup>: Output units of 'ft' for 'pre_mission.core_subsystems.core_geometry.characteristic_lengths.aircraft:nacelle:characteristic_length' are incompatible with input units of 'unitless' for 'traj.param_comp.parameters:aircraft:nacelle:characteristic_length'.
   <model> <class AviaryGroup>: Output units of 'ft**2' for 'pre_mission.core_subsystems.core_geometry.nacelles.aircraft:nacelle:wetted_area' are incompatible with input units of 'unitless' for 'traj.param_comp.parameters:aircraft:nacelle:wetted_area'.

If don't, unit test for FLOPS aero builder fails.

I have to come back to it later.

@jkirk5 jkirk5 added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@jkirk5 jkirk5 added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2025
@Kenneth-T-Moore Kenneth-T-Moore added this pull request to the merge queue Feb 25, 2025
Merged via the queue into OpenMDAO:main with commit df966b5 Feb 25, 2025
6 checks passed
@xjjiang xjjiang deleted the test_flops_aero_builder branch February 26, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants