-
Notifications
You must be signed in to change notification settings - Fork 98
Test FLOPS Aero Builder #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kenneth-T-Moore
merged 51 commits into
OpenMDAO:main
from
xjjiang:test_flops_aero_builder
Feb 25, 2025
Merged
Test FLOPS Aero Builder #619
Kenneth-T-Moore
merged 51 commits into
OpenMDAO:main
from
xjjiang:test_flops_aero_builder
Feb 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion is generated.
jkirk5
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could use a second opinion on the use of _unspecified
from another reviewer
Kenneth-T-Moore
approved these changes
Jan 29, 2025
…y into test_flops_aero_builder
…y into test_flops_aero_builder
On line 469 here: If I add
If don't, unit test for FLOPS aero builder fails. I have to come back to it later. |
…ACTOR, Aircraft.Wing.FORM_FACTOR to AERO_2DOF_INPUTS in aerodynamics_builder.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a unit test file for FLOPS based aerodynamic builder (20 unit tests).
Note: the unit test file for GASP based aerodynamic builder has to be put on hold because it depends on the consistency of default values in several GASP based components.
Related Issues
Backwards incompatibilities
None
New Dependencies
None