Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update value of Mission.Summary.RANGE for fallout missions #630

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cmbenne3
Copy link
Contributor

Summary

This PR makes some changes to methods for level 2 to remove the variable "actual_range" and replace it with Mission.Summary.RANGE

This is particularly helpful for fallout missions where this value was not being updated as expected.

Related Issues

None

Backwards incompatibilities

None

New Dependencies

None

@cmbenne3 cmbenne3 requested review from ehariton and crecine December 12, 2024 18:08
@cmbenne3
Copy link
Contributor Author

cmbenne3 commented Jan 9, 2025

@jkirk5 @Kenneth-T-Moore:
I ran a comparison of prob.model.list_vars for 'main' compared to this branch 'fallout_summary_range' for the test_bench_GwGm_shooting test and think that the value used for the near equal check of Mission.Summary.RANGE needs to be updated.

image

The check that fails is:
image

This is because in 'main' the Mission.Summary.Range value is simply overwritten with the 'Target Range' value, which is just incorrect it doesn't actually tell you anything about the values output from the optimizer on how far that aircraft has actually flown . I don't know much about the shooting method and so I'm not sure why the range residual hasn't converged to zero in either case. This probably needs to be investigated further, but perhaps as a separate issue. For now what are your thoughts on updating the assert near equal value to 3765.48?

GwGm_shooting_test_error_root_cause.xlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants