Fix Sequence Input

[t0mdavid-m]

Fixes bug where we are trying to access parameters before page setup.

Summary by CodeRabbit

• Bug Fixes

  • Improved startup stability by initializing configuration earlier, preventing rare errors during launch.
  • Ensures parameters are consistently available, resolving intermittent issues when saving settings.
  • Reduces edge cases where pages failed to load due to missing initialization.

• Performance

  • Minor improvement to app responsiveness at startup by preparing required settings upfront.

[coderabbitai]

Walkthrough

Moves page_setup() call to the top of FLASHDeconvSequenceInput module, initializing a new global variable params at import time. The rest of the module continues to use params, including later calls like save_params(params).

Changes

Cohort / File(s)	Summary
Initialization timing update content/FLASHDeconv/FLASHDeconvSequenceInput.py	Added module-level params = page_setup() at top; removed/deprioritized bottom invocation. Ensures params exists early for subsequent usage, including save_params(params). No other logic changes reported.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Python
    participant Module as FLASHDeconvSequenceInput.py
    participant Setup as page_setup()
    participant Store as save_params(...)

    Python->>Module: Import module
    Module->>Setup: page_setup()
    Setup-->>Module: params
    Note right of Module: params is now globally available post-import

    Module->>Store: save_params(params)
    Store-->>Module: ack

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A whisk of keys, a timely hop,
I moved setup right to the top.
Params now greet the morning sun,
Ready before the tasks are begun.
Thump-thump—compile, no delays,
Carrot-shaped flags for cleaner ways. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title “Fix Sequence Input” succinctly names the component under change—the sequence input functionality—and indicates that a bug is being addressed, which aligns with the pull request’s goal of correcting parameter initialization timing in the FLASHDeconvSequenceInput module. It is a single clear sentence, avoids extraneous detail, and highlights the main change.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_sequence_input

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99dd5a2 and ced8e89.

📒 Files selected for processing (1)

• content/FLASHDeconv/FLASHDeconvSequenceInput.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

content/FLASHDeconv/FLASHDeconvSequenceInput.py (1)

src/common/common.py (1)

• page_setup (117-319)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build-openms
• GitHub Check: build-full-app

🔇 Additional comments (1)

content/FLASHDeconv/FLASHDeconvSequenceInput.py (1)

7-8: Initialization ordering fix looks solid

Running page_setup() before instantiating FileManager guarantees st.session_state["workspace"] is ready, eliminating the prior init-time KeyError. Matches the bug description—nice cleanup.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}