Skip to content

Conversation

t0mdavid-m
Copy link
Member

@t0mdavid-m t0mdavid-m commented Sep 29, 2025

Should resolve incompatibilities with older CPUs.

Summary by CodeRabbit

  • Chores
    • Updated Windows build pipeline to improve reliability by switching to a long-term support CPU package for a data processing dependency and removing the conflicting variant.
    • Enhances build stability and reduces installation failures on Windows environments.
    • No changes to app features or user workflows.

Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

Walkthrough

The Windows GitHub Actions workflow modifies the “Install Required Packages” step from a single command to a multi-line script that now uninstalls polars and installs polars-lts-cpu (>=1.0) after installing requirements.

Changes

Cohort / File(s) Summary
CI workflow update
\.github/workflows/build-windows-executable-app.yaml
Updated Windows build step: changed to multi-line script; keeps requirements install, adds pip uninstall polars -y, then pip install "polars-lts-cpu>=1.0"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I hop through YAML fields at night,
Swapping wheels to make it right—
Polars out, LTS in queue,
Windows builds now hop on through.
With whiskers twitch and CI light,
The carrots compile, crisp and bright. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly conveys the core change of this PR, namely switching the Windows build to use the Polars LTS CPU package, and it is both concise and directly aligned with the modifications in the workflow.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch use_polars_lts

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3471ae and f07c301.

📒 Files selected for processing (1)
  • .github/workflows/build-windows-executable-app.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build-windows-executable-app.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-openms
  • GitHub Check: build-full-app

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99dd5a2 and 8ff702f.

📒 Files selected for processing (1)
  • .github/workflows/build-windows-executable-app.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-openms
  • GitHub Check: build-full-app

Comment on lines 277 to 281
run: |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars
.\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

CI will hang on interactive uninstall; tighten install command.

  • pip uninstall prompts in CI; add -y (or --yes).
  • Use a canonical spec without spaces: "polars-lts-cpu>=1.0".
  • Consider forcing upgrade and verifying env with pip check.

Apply:

-        .\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
-        .\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars
-        .\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0'
+        .\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
+        .\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall -y polars
+        .\python-${{ env.PYTHON_VERSION }}\python -m pip install --upgrade --force-reinstall "polars-lts-cpu>=1.0"
+        .\python-${{ env.PYTHON_VERSION }}\python -m pip check
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run: |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars
.\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0'
run: |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall -y polars
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --upgrade --force-reinstall "polars-lts-cpu>=1.0"
.\python-${{ env.PYTHON_VERSION }}\python -m pip check
🤖 Prompt for AI Agents
.github/workflows/build-windows-executable-app.yaml around lines 277 to 281: the
pip uninstall will hang waiting for confirmation and the polars spec has an
extra space; change the uninstall command to be non-interactive (add -y or
--yes), replace the package spec with a canonical form without spaces
("polars-lts-cpu>=1.0"), and tighten the install to force an upgrade/consistent
install (e.g., add --upgrade or --force-reinstall) and then run a pip check to
verify the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant