-
Notifications
You must be signed in to change notification settings - Fork 0
On Windows use Polars LTS CPU #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe Windows GitHub Actions workflow modifies the “Install Required Packages” step from a single command to a multi-line script that now uninstalls polars and installs polars-lts-cpu (>=1.0) after installing requirements. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-windows-executable-app.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-openms
- GitHub Check: build-full-app
run: | | ||
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location | ||
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars | ||
.\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0' | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI will hang on interactive uninstall; tighten install command.
- pip uninstall prompts in CI; add -y (or --yes).
- Use a canonical spec without spaces: "polars-lts-cpu>=1.0".
- Consider forcing upgrade and verifying env with pip check.
Apply:
- .\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
- .\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars
- .\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0'
+ .\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location
+ .\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall -y polars
+ .\python-${{ env.PYTHON_VERSION }}\python -m pip install --upgrade --force-reinstall "polars-lts-cpu>=1.0"
+ .\python-${{ env.PYTHON_VERSION }}\python -m pip check
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
run: | | |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location | |
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall polars | |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install 'polars-lts-cpu >= 1.0' | |
run: | | |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --force-reinstall -r requirements.txt --no-warn-script-location | |
.\python-${{ env.PYTHON_VERSION }}\python -m pip uninstall -y polars | |
.\python-${{ env.PYTHON_VERSION }}\python -m pip install --upgrade --force-reinstall "polars-lts-cpu>=1.0" | |
.\python-${{ env.PYTHON_VERSION }}\python -m pip check |
🤖 Prompt for AI Agents
.github/workflows/build-windows-executable-app.yaml around lines 277 to 281: the
pip uninstall will hang waiting for confirmation and the polars spec has an
extra space; change the uninstall command to be non-interactive (add -y or
--yes), replace the package spec with a canonical form without spaces
("polars-lts-cpu>=1.0"), and tighten the install to force an upgrade/consistent
install (e.g., add --upgrade or --force-reinstall) and then run a pip check to
verify the environment.
Should resolve incompatibilities with older CPUs.
Summary by CodeRabbit