Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Google Analytics 4 code #3342

Merged
merged 32 commits into from
Jun 23, 2023
Merged

Improvements to Google Analytics 4 code #3342

merged 32 commits into from
Jun 23, 2023

Conversation

empiricompany
Copy link
Contributor

Description (*)

This refactor some code, avoid notice (#3323) and fix quantity in purchase

Related Pull Requests

#3323

empiricompany and others added 22 commits June 8, 2023 08:50
@empiricompany @fballiano
Enhanced Google Analytics 4 Integration and Ecommerce Tracking Improv…
20f7b9c 
…ements
@empiricompany
string to float 0.00 value
a5aa41f
@fballiano
PHPCS
9ac5f48
@fballiano
PHPCS
695f6b3
@fballiano
PHPCS
c0c6e75
@fballiano
whitespace
9977ad4
@empiricompany
remove 3rd party partial support
e15f0e6
@fballiano
case
9fe6da1
@empiricompany @fballiano
Update app/code/core/Mage/GoogleAnalytics/etc/system.xml
153efca 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@empiricompany @fballiano
Update app/code/core/Mage/GoogleAnalytics/etc/system.xml
a13656b 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@empiricompany @fballiano
Update app/code/core/Mage/GoogleAnalytics/etc/system.xml
df9db8a 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@empiricompany
add translations
d1f6cf3
@empiricompany
fix item_brand false or null in analytics view
2ff3161
@empiricompany
fire cart actions events also if redirect_to_cart is false
f967f4b
@empiricompany
catch multi products cart actions
bc5b167
@empiricompany
item_category tracking for ga4 ecommerce events
1f6f3e7
@empiricompany
PHPCS
cce8991
@empiricompany
PHPCS
5694d3a
@fballiano
cosmetic
eb3c49d
@fballiano
suggestion by @addison74
c594404
@fballiano
Merge branch 'main' into ga4-improvement
1f6d227
@empiricompany
fix notice PR 3323 and same improvement
db60c7b
@github-actions github-actions bot added Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Template : base Relates to base template translations Relates to app/locale labels Jun 21, 2023
@fballiano
Copy link
Contributor

@empiricompany how did you open this PR with conflicts already? :-))) maybe you had an old branch?

@github-actions github-actions bot removed the Template : base Relates to base template label Jun 21, 2023
@empiricompany
Copy link
Contributor Author

@empiricompany how did you open this PR with conflicts already? :-))) maybe you had an old branch?

yes sorry now is aligned

empiricompany and others added 2 commits June 21, 2023 10:37
@empiricompany @fballiano
Update app/code/core/Mage/GoogleAnalytics/Helper/Data.php
9bc325f 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@empiricompany @fballiano
Update app/code/core/Mage/GoogleAnalytics/Helper/Data.php
b66c7f0 
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
fballiano
fballiano previously approved these changes Jun 21, 2023
View reviewed changes
@fballiano fballiano mentioned this pull request Jun 21, 2023
Closed
@fballiano fballiano changed the title Ga4 improvement Improvements to Google Analytics 4 code Jun 21, 2023
@empiricompany @elidrissidev
Update app/code/core/Mage/GoogleAnalytics/Block/Ga.php
929a1eb 
Co-authored-by: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com>
@pquerner
Copy link
Contributor

See #3228 for more discussion as I identified wrong types we sent to Google. Apparantly Google auto-converts it someway to the backend and it didnt break anything. (ie. not sending "number" values but "string" values.)

@empiricompany
Copy link
Contributor Author

Unfortunately, a proper way to test it is to wait for 24 hours and hope that there are no bugs or misalignments on GA4, which is constantly changing.

@pquerner
Copy link
Contributor

Unfortunately, a proper way to test it is to wait for 24 hours and hope that there are no bugs or misalignments on GA4, which is constantly changing.

Not true. You can turn on debug view and see the data "coming in". I've tested that with numbers/string values and they came in both the same, hence my comment about "they get parsed before something".

@empiricompany
Copy link
Contributor Author

Unfortunately, a proper way to test it is to wait for 24 hours and hope that there are no bugs or misalignments on GA4, which is constantly changing.

Not true. You can turn on debug view and see the data "coming in". I've tested that with numbers/string values and they came in both the same, hence my comment about "they get parsed before something".

Yes, but for example, the 'amount' is not as you send it It's multiplied by 1000 or something like that, and I can tell you from experience that it doesn't help much. That's why I have set up the log on Magento to know exactly the JSON format sent in the data layer.

@elidrissidev
Copy link
Member

Ready to approve if the new changes were tested.

@empiricompany
Copy link
Contributor Author

Ready to approve if the new changes were tested.

obviously for me that I am the author is tested but you can test it too

@fballiano fballiano merged commit b4cee73 into OpenMage:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elidrissidev elidrissidev elidrissidev approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: GoogleAnalytics Relates to Mage_GoogleAnalytics translations Relates to app/locale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@empiricompany @fballiano @pquerner @elidrissidev