Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview PR in gitpod #4175

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Preview PR in gitpod #4175

merged 3 commits into from
Sep 19, 2024

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 30, 2024

This is work in progress ...

Needs to be merged for further tests.

PR should show a "open in gitpod" button, to preview current PR with installed OpenMage.

@sreichel sreichel mentioned this pull request Aug 30, 2024
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a screenshot of where the button appears?

@sreichel
Copy link
Contributor Author

I have no screenshot right now. I'll provide one later ... or take a look at DDEV repo that uses gitpod too.

@sreichel
Copy link
Contributor Author

Give it a try?

We can roll back if it does not work.

@kiatng kiatng merged commit bdcfba4 into OpenMage:main Sep 19, 2024
1 check passed
@sreichel sreichel deleted the gitpod-update branch September 19, 2024 03:17
@sreichel
Copy link
Contributor Author

@colinmollenhour is there something to configure/enable in github admin ?

@colinmollenhour
Copy link
Member

It's already configured and enabled, someone else must have a while back. I think maybe the addBadge option only applies to new PRs so please check on the next new PR.

@colinmollenhour
Copy link
Member

I'm not sure how to reach Project Settings..
image

In my GitPod dashboard I seem to only be able to do anything related to private repos, I don't see how to do anything with an organization repo.

It does "work" with prefixing a PR repo URL with https://gitpod.io/# as far is it launches a workspace, but the url gets a 404 although it does look like an nfinx 404 if that means anything..
image

@colinmollenhour
Copy link
Member

I uninstalled and re-installed and it opened a page in Gitpod dashboard with this:
image
So I think you just use the prefix or the browser extension.. Seems like the addBadge and addComment are no longer supported?

@colinmollenhour
Copy link
Member

The startup script is broken
image

@sreichel
Copy link
Contributor Author

sreichel commented Sep 21, 2024

@colinmollenhour thanks.

For some reason i used non-existing php8.3-image.

I have

  • changed it to 7.4
  • added an action to create the gitpod link

This works so far, gitpod opens w/o error, but port 8000 (required for preview?) isn't available.

Can you please take a look at it?

Test here: openmage-strict#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants