-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview PR in gitpod #4175
Preview PR in gitpod #4175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a screenshot of where the button appears?
I have no screenshot right now. I'll provide one later ... or take a look at DDEV repo that uses gitpod too. |
Give it a try? We can roll back if it does not work. |
@colinmollenhour is there something to configure/enable in github admin ? |
It's already configured and enabled, someone else must have a while back. I think maybe the addBadge option only applies to new PRs so please check on the next new PR. |
I'm not sure how to reach Project Settings.. In my GitPod dashboard I seem to only be able to do anything related to private repos, I don't see how to do anything with an organization repo. It does "work" with prefixing a PR repo URL with https://gitpod.io/# as far is it launches a workspace, but the url gets a 404 although it does look like an nfinx 404 if that means anything.. |
@colinmollenhour thanks. For some reason i used non-existing php8.3-image. I have
This works so far, gitpod opens w/o error, but port 8000 (required for preview?) isn't available. Can you please take a look at it? Test here: openmage-strict#55 |
This is work in progress ...
Needs to be merged for further tests.
PR should show a "open in gitpod" button, to preview current PR with installed OpenMage.