Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worklflow: update copyright monthly #4176

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 1, 2024

@addison74
Copy link
Contributor

This is a good idea.

addison74
addison74 previously approved these changes Sep 1, 2024
@kiatng
Copy link
Contributor

kiatng commented Sep 6, 2024

Isn't copyright update a yearly thing?

@sreichel
Copy link
Contributor Author

sreichel commented Sep 6, 2024

This script updates copyright info based on files last commit date.

It's often missed to update it along a PR. So monthly check seems okay to me.

Do you suggest to update all files at the beginning of a year?

@sreichel sreichel mentioned this pull request Sep 9, 2024
Copy link
Contributor

@mattdavenport mattdavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think basing off of the last commit is best, as it is also an indicator of the activity of the project itself. For instance, going to an old website you can tell sometimes if it hasn't been updated based on the copyright tag.

@sreichel sreichel merged commit 1be5f17 into OpenMage:main Sep 10, 2024
18 checks passed
@sreichel sreichel deleted the copyright-workflow branch September 10, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants