-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing/wrong admin _setActiveMenu()
#4209
Conversation
when you take PRs from other repos you should at least mention them: MahoCommerce/maho#12 @sreichel fo you remember that you were accusing somebody of this same thing? |
Dear @fballiano, these changes are based on this issue #4207 and aren't identical to yours. On your repo: +131 −110 lines changed Btw ... i can see a lot of "OM PR xyz" at https://github.com/MahoCommerce/maho/commits/main/. Have you left any credits? For sure i'll leave credits when I should pick up your or anybody else work. Edit 22/09: You have removed the complete history, so it looks like all work was done by you? (https://github.com/MahoCommerce/maho/graphs/contributors) |
Removed offtopic. Backuped screenshot. |
As a reviewer of this PR, I acknowledge that this PR should credit @tmewes original MahoCommerce/maho#12, which is precedent to this one. @fballiano Thanks for pointing this out. |
Description (*)
Some sections are not correctly highlighted when active.