Fixes configurable swatch color picker in legacy admin theme #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Template : admin
|
@empiricompany ... maybe another improvement ... take the given color-string and automatically add the swatch-color. https://stackoverflow.com/questions/48484767/javascript-check-if-string-is-valid-css-color |
|
Only one warning remains in the Chromium browsers console. That delete button should be 21px height, to keep the same proportion with similar buttons (e.g. the ones in Product Edit > Custom Options). Even the [ x Delete] button at the end of the row is 21px. |
addison74
approved these changes
Sep 22, 2024
|
If you solve the warning it will be perfect. |
|
Nothing is perfect :P I tried, but its not worth the time atm. Sorry. |
|
@empiricompany can you please check this? Re-used your code, only change template for legacy theme and added default value for swatch (to get rid of the browser errors) |
kiatng
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
... one error left in Chrome. (maybe someone has an idea to fix it - i have not)
Related Pull Requests
Fixed Issues (if relevant)