fix: Improve form accessibility: add explicit id/for associations to inputs#4
Merged
tompscanlan merged 2 commits intoOpenMeet-Team:mainfrom Dec 28, 2025
Conversation
- Add for="ai-consent" to consent checkbox label in create_survey.templ - Add for="example-select" to example selector label in create_survey.templ - Add id="share-url-short" and for attribute to share link label in share.templ - Add id="share-url-aturi" and for attribute to ATProto URI label in share.templ - Add aria-label to select-all checkbox in my_data.templ - Add aria-label to individual record checkboxes in my_data.templ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
Contributor
|
Looks like I didn't finish setting up github. Ignore the build failure, I'm looking into it. |
tompscanlan
reviewed
Dec 27, 2025
Contributor
tompscanlan
left a comment
tompscanlan
left a comment
There was a problem hiding this comment.
Thanks for your contribution! These changes look good to me, but
I'm still seeing the following:
which I think indicates we still need a change to the survey_form. Can you do the same there?
2 tasks
Add explicit id attributes to radio, checkbox, and textarea inputs in survey_form.templ, with corresponding for attributes on their labels. This improves form accessibility by creating proper label-input associations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Done! Added id/for associations to survey_form.templ as well. |
majiayu000
deleted the
fix-2-improve-form-accessibility-add-explicit-
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2
Changes
internal/templates/create_survey.templinternal/templates/my_data.templinternal/templates/share.templ