Skip to content

Conversation

@galalen
Copy link
Contributor

@galalen galalen commented Apr 13, 2021

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@galalen galalen changed the title [WIP] add base checkpoint apis [WIP] add checkpoint apis Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #319 (ae3cfed) into dev (c58854b) will increase coverage by 0.92%.
The diff coverage is 34.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #319      +/-   ##
==========================================
+ Coverage   30.83%   31.76%   +0.92%     
==========================================
  Files          54       56       +2     
  Lines        1456     1571     +115     
  Branches      229      249      +20     
==========================================
+ Hits          449      499      +50     
- Misses        964     1025      +61     
- Partials       43       47       +4     
Impacted Files Coverage Δ
.../main/java/org/openmined/syft/execution/SyftJob.kt 14.06% <0.00%> (-5.09%) ⬇️
...java/org/openmined/syft/execution/TrainingState.kt 0.00% <0.00%> (ø)
...mined/syft/execution/checkpoint/ModelCheckPoint.kt 68.75% <68.75%> (ø)
.../syft/execution/checkpoint/CheckPointSerializer.kt 72.72% <72.72%> (ø)
...enmined/syft/networking/datamodels/ClientConfig.kt 20.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58854b...ae3cfed. Read the comment docs.

dataLoader: DataLoader,
trainingParameters: TrainingParameters
trainingParameters: TrainingParameters,
checkPointSerializer: CheckPointSerializer? = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pass this in the constructor?
Also, why clientConfig had to be passed here and not in the constructor? Can a job execute different plans with different client configurations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because clientConfig will only be available when the job is on ReadyStatus

Copy link
Member

@mccorby mccorby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@galalen galalen changed the title [WIP] add checkpoint apis add checkpoint apis Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants