Dockerfiles with OMPython for OMSimulator CI on Jenkins #6
Conversation
|
@sjoelund Where do we want to upload the images to? Should they be public or private? Also both Dockerfiles can probably be merged into one, but I'm not so sure how to do that. |
AnHeuermann
force-pushed
the
OMPython
branch
2 times, most recently
from
b84e610
to
4a4d55e
Compare
AnHeuermann
force-pushed
the
OMPython
branch
from
d87e8e3
to
19cf867
Compare
| && apt-get clean | ||
|
|
||
| # Install OMC and OMPython | ||
| RUN for deb in deb deb-src; do echo "$deb http://build.openmodelica.org/apt focal stable"; done | tee /etc/apt/sources.list.d/openmodelica.list \ |
There was a problem hiding this comment.
This should use a fixed version, like https://build.openmodelica.org/omc/builds/linux/releases/1.16.2/
But you could just use FROM openmodelica/openmodelica:v1.16.2-ompython instead, right? And only install pandas to it.
There was a problem hiding this comment.
We could do that. Where is the dockerfile for that one saved? I think we should have them all in one place.
There was a problem hiding this comment.
https://github.com/OpenModelica/OpenModelicaDockerImages uses Docker Hub's settings to build from this repository's branches. It's pretty slow and error-prone though, and I want to eventually move it to Jenkins.
| RUN groupadd -g 1000 testUser \ | ||
| && useradd -m -r -u 1000 -g testUser testUser | ||
|
|
||
| USER testUser | ||
| ENV USER=testUser |
There was a problem hiding this comment.
Users belong in the docker command, not the image (in particular the id)
|
This PR is a bit stuck, but we should backup the Jenkinsfile that is currently running for the FMI-Cross-Checks for OMSimulator. I'm not sure how I need to change the Dockerfiles in this PR so it can be merged. @sjoelund Could you make some concrete suggestions? |
AnHeuermann
force-pushed
the
OMPython
branch
from
19cf867
to
7826f2b
Compare
|
It's not perfect, but I updated the Dockerfiles to not create a user group. We should merge this, as it now used by Jenkins for a long time and we need some back-up of the scripts. |
|
Why does it use 4 layers (run commands) in the dockerfiles. If you have too many layers you can get some warnings. |
AnHeuermann
force-pushed
the
OMPython
branch
from
7826f2b
to
3fbf376
Compare
|
It's faster to re-build when changing one of the later layers. But I changed it to be in (mostly) one layer. |
|
|
The Build tag should be changed to some different.
These docker images are used on Jenkins for FMI Cross Checks of OMSimulator. OMPython is used for verification, pandas and git used in the Python scripts to run the actual test.