Add an output raster: sum of flux [com4]

[PaulaSp3]

• fix some small bugs (for log file)
• fix the bug in the flux distribution (including a Flag for switching on the 'old/wrong' version) - I did not write it in the documentation yet, I'm not sure if it is necessary?
• adapt the documentation: possible output files
• add two new output rasters: routing flux summed up over all paths (routFluxSum) & deposited flux summed up over all paths (depFluxSum)
• Added docstrings to function. (I almost didn't change existing docstrings/ documentation)

[pep8speaks]

Hello @PaulaSp3! Thanks for updating this PR.

• In the file avaframe/com4FlowPy/com4FlowPy.py:

Line 616:13: E265 block comment should start with '# '
Line 615:13: E265 block comment should start with '# '
Line 564:121: E501 line too long (121 > 120 characters)
Line 343:121: E501 line too long (121 > 120 characters)

• In the file avaframe/com4FlowPy/rasterIo.py:

Line 121:5: E722 do not use bare 'except'
Line 112:5: E722 do not use bare 'except'
Line 87:5: E722 do not use bare 'except'

Comment last updated at 2025-01-16 09:53:57 UTC

[ahuber-bfw]

• Thx for the docstrings 👍
• Results with new/old flux distribution version look similar enough 👍
• routFluxSum is a cool new output file 👍 :)
• I'm not 100% sure how to interpret the depFluxSum output yet
• looks fine apart from minor changes

[ahuber-bfw]

Looks ok from my side now!

• apart from the flux-conservation the PR does not introduce any major changes to the code, but adds some useful improvements (documentation, docStrings, etc.)
• @PaulaSp3: maybe you can run some tests if the checkInputParameterValues function behaves as expected - I only checked/tested this function with the global parameters (which works) - but not with the variable input rasters!

[fso42]

Standardtests ok, apart from Kot, Hof

[qlty-cloud-legacy]

Code Climate has analyzed commit 1606e1a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 2.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.2% (-0.2% change).

View more on Code Climate.